Bump axios from 0.27.2 to 1.1.3 in /dashboard #5475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
✅ Deploy Preview for kubeapps-dev canceled.
|
antgamdia
previously approved these changes
Oct 18, 2022
Bumps [axios](https://github.com/axios/axios) from 0.27.2 to 1.1.3. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v0.27.2...v1.1.3) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/dashboard/axios-1.1.3
branch
from
6796f40 to
5fe9291
Compare
|
There are some incompatible changes, but, the main issue is that we are using "moxios" for mocking axios request and this project seems to be inactive (see axios/moxios#98). Maybe we will have to migrate to https://www.npmjs.com/package/axios-mock-adapter |
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Signed-off-by: Antonio Gamez Diaz <[email protected]> Conflicts: dashboard/package.json
antgamdia
requested review from
castelblanque
and removed request for
antgamdia
|
Last PR on Moxios dates back to March, 2021. I agree on migrating to another tool like https://www.npmjs.com/package/axios-mock-adapter or similar. |
Exactly, that's what I've done in this PR indeed :P and why I asked for a review |
castelblanque
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps axios from 0.27.2 to 1.1.3.
Release notes
Sourced from axios's releases.
... (truncated)
Changelog
Sourced from axios's changelog.
Commits
9bd5321chore: release 1.1.3b0ebf9fFix: Don't add null values to query string. (#5108)ef1c48afix: eep top-level export same with static properties (#5109)9d4b016feat: added custom params serializer support; (#5113)ed19414fix: addedAxiosHeadersinAxiosHeaderValue(#5103)717f476fix: restore proxy config backwards compatibility with 0.x (#5097)83454a5chore: added progress capturing section to the docs; (#5084)e7b3f55chore: update issue template (#5061)eedd9aachore: fixing comments typo (#5054)110ae9afix: handling of array values for AxiosHeaders (#5085)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)