[velero] Default to empty volumeSnapshotLocation.

[toothbrush]

Special notes for your reviewer:

I ran into an issue where i needed to override volumeSnapshotLocation: [] in my values.yaml file, otherwise i received the following scary error:

Error: UPGRADE FAILED: post-upgrade hooks failed: unable to build kubernetes object for post-upgrade hook velero/templates/volumesnapshotlocation.yaml: error validating "": error validating data: ValidationError(VolumeSnapshotLocation.spec): missing required field "provider" in io.velero.v1.VolumeSnapshotLocation.spec

I believe that the default behaviour from v3 of the chart is preserved, because previously, leaving the value of volumeSnapshotLocation with empty values:

helm-charts/charts/velero/values.yaml

Lines 280 to 288 in 8f7795d

	volumeSnapshotLocation:
	# name is the name of the volume snapshot location where snapshots are being taken. Required.
	name:
	# provider is the name for the volume snapshot provider. If omitted
	# `configuration.provider` will be used instead.
	provider:
	# Additional provider-specific configuration. See link above
	# for details of required/optional fields for your provider.
	config: {}

Would prevent volume snapshots from working. I think. If i understand correctly 😅

Checklist

• DCO signed
• Chart Version bumped
• Variables are documented in the values.yaml or README.md
• Title of the PR starts with chart name (e.g. [velero])

[jenting]

@toothbrush Thanks for your contribution.

Perhaps you could change snapshotsEnabled: false in your values.yaml, without having to make code change.
Please let me know if it works for you or not.

[toothbrush]

Perhaps you could change snapshotsEnabled: false in your values.yaml, without having to make code change.
Please let me know if it works for you or not.

That's actually what i ended up doing, after staring more at the Helm charts 😃

However i still believe it's a bug that in the default configuration, this Helm chart (appears to) result in broken config (i.e, an invalid entry in the volumeSnapshotLocation slice).

[jenting]

Please leave the comment description as is.

Also, it's be good if you could update backupStorageLocation as well.