This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Fix disabling user accounts in an Org under certain conditions #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix for issue vmware-archive#722. This fixes disabling user accounts in an Org when no other changes are made to a user account.
|
Can this be reviewed and merged? |
|
Bump |
matt852
changed the title
|
@rocknes Can you please review? |
|
Bump @rocknes @ltimothy7 |
ltimothy7
reviewed
Jun 14, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matt852)
ltimothy7
reviewed
Jun 14, 2021
There was a problem hiding this comment.
Reviewable status:
|
@ltimothy7 is there anything else you're waiting on me for to get this merged? |
matt852
commented
Apr 3, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:
|
@ltimothy7 can we get this merged in please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help us process your pull request efficiently, please include:
Bugfix for issue #722. This fixes disabling user accounts in an Org when no other changes are made to a user account.
documentation. If the pull request contains multiple commits with
detailed messages, refer to those instead
Details are included in submitted issue #722 (pasted below):
There is a bug that prevents disabling a user in an Org. I'll be submitting a PR for this shortly.
File: pyvcloud/vcd/org.py
Line: 1019
Current line:
if is_enabled or role_name or password:
Issue: If the only modification being made to a user is to disable the account, this will ALWAYS skip past this IF statement, as "is_enabled" is a boolean and evaluates to False. This works for enabling users, as "is_enabled" evaluates to True and enters the IF statement.
This change is