Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Fix - can't toggle gateway high availability #694

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix - can't toggle gateway high availability #694

wants to merge 1 commit into from

Conversation

azzamsa
Copy link
Contributor

@azzamsa azzamsa commented Jul 24, 2020 •
edited by ckolovson
Loading 

        if ha: # <----
            gateway.Configuration.HaEnabled = E.HaEnabled(ha)

if ha value is set to False the code will never be executed. So that the Gateway High Availability will never be Disabled.

        if ha is not None: # <----
            gateway.Configuration.HaEnabled = E.HaEnabled(ha)

This change is Reviewable

mukultaneja
mukultaneja reviewed Sep 8, 2020
View reviewed changes
Copy link
Collaborator

@mukultaneja mukultaneja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@azzamsa
Copy link
Contributor Author

azzamsa commented Nov 22, 2021

Any update about this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mukultaneja mukultaneja mukultaneja left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@azzamsa @mukultaneja