Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scripts for patches where content is not available. #2542

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

Daribon
Copy link
Contributor

@Daribon Daribon commented Mar 7, 2024

🍰 Pullrequest

This PR stops compiler from building scripts where the content is not available. For patch 1.12.1, this PR does nothing.
As this removes plenty of script files when building for lower patch, the file size difference between patch 1.12.1 mangosd and patch 1.6.1 mangosd is 495 kb.

Full 1.12.1 build on a 5800x:
devenv_2qwWuLwgt1
Full 1.6.1 build on a 5800x:
devenv_2w1O8Ib6ab

If below patch 1.11, Naxxramas and Scourge Invasion will not build.
If below patch 1.9, AQ, War Effort and Omen will not build.
If below patch 1.8, Dragons of Nightmare will not build.
If below patch 1.7, AB and ZG will not build.
If below patch 1.6, BWL will not build.

All patches build successfully. No server crashes from my testing in game.

Proof

  • None

Issues

  • None

How2Test

  • None

Todo / Checklist

  • Attempt to remove War Effort when building for lower patch.

@shudza
Copy link
Contributor

shudza commented Mar 8, 2024

Can you remove war effort too? Link

@heyitsbench
Copy link

Can you remove war effort too?

It's in the todo list.

@shudza
Copy link
Contributor

shudza commented Mar 8, 2024

warreffort.PATCH

Something like this?

@Daribon
Copy link
Contributor Author

Daribon commented Mar 8, 2024

warreffort.PATCH

Something like this?

Thanks. Added it to the PR.

The only issue atm is that ScriptMgr will cry that script_name from DB can't be found when loading mangosd, since those scripts are not compiled on certain patches.
WindowsTerminal_qMI41Peq78

@0blu 0blu added the CPP A issue / PR which references CPP code label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CPP A issue / PR which references CPP code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants