Invisible auras should be sent to client and take an aura slot.

[balakethelock]

🍰 Pullrequest

Persistent auras should be sent to client and take an aura slot no matter if their effect is exclusive damage or not.

In addition

case SPELL_EFFECT_APPLY_AREA_AURA_PET:
            case SPELL_EFFECT_APPLY_AREA_AURA_PARTY:
                // passive auras (except totem auras) do not get placed in caster slot
                return (m_target != caster || totemAura || !m_isPassive) && m_auras[i]->GetModifier()->m_auraname != SPELL_AURA_NONE;

The aforementioned appears entirely redundant, vanilla has no passive area auras or pet auras that warrant exclusion from buff cap.

Proof

Classic data about debuff priorities. In the bottom you can find consecration, volley, blizzard, rain of fire. Confirming that they take a debuff slot and can push away existing debuffs.

Youtube video timestamp 45:11 look at the rain of fire visual effect on the player, and the debuff applying on his scrolling combat text.

Grainy video, but a source from 2005 vanilla.

Issues

• None

How2Test

Auras.sent.to.client.mp4

Todo / Checklist

• None