Hammer of Wrath does not use weapon skill #2086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest commit accidentally made Hammer of Wrath try to use ranged weapon skill. Since paladins don't have any, it defaulted to zero. The bug made the ability have a very high miss chance.
|
I addressed it another way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Recent commit to make special abilities use weapon skill competely broke Hammer of Wrath. Made it use ranged weapon skill (defaulted to 0 on paladin who don't have ranged weapon skill to begin with, the bug made the ability miss more than 50% of the time when fighting same level enemies)
Hammer of wrath seems to be the sole exception that shouldn't use weapon skill ever.
Proof
Videos from classic ptr thanks to Brotalnia
Issues
How2Test
2023-07-15.01-43-44.mp4
Todo / Checklist