gui bugfix: make workspaces navigatable #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds a `to` property on `getWorkspaceItems` for the `importer` - on `getItemQuery` we get the query based on the `to.name` not the `spec.name` - creates tests to check if the query will change on side-item click
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
lukekarrys
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the workspaces to be navigatable on the gui explorer view, and adds tests for the
selected-item/index.tsxview to check ifquerywill actually change when aside-itemis clicked for a workspace item.The major change is adding a
toproperty on theworkspaceitems:items.push({ + ...importer, + to: importer as QueryResponseNode, id: importer.id, title, version: importer.version || '', name: importer.name || '', stacked: false, - size: 1, labels: undefined, + size: 1, }) }and updating the
getItemQueryto use thetoproperty:const getItemQuery = (item: GridItemData) => { if (!item.to) return '' - const name = item.spec?.name ? `#${item.spec.name}` : '' + const name = item.to.name ? `#${item.to.name}` : '' return name.trim() }Other Changes
workspacelabel{ref}to${ref}in theselected-item'sitem-header