Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model] Add Idefics3 support #9767

Merged
merged 29 commits into from
Nov 6, 2024
Merged

[Model] Add Idefics3 support #9767

merged 29 commits into from
Nov 6, 2024
+723 −1

Conversation

jeejeelee
Copy link
Contributor

@jeejeelee jeejeelee commented Oct 28, 2024 •
edited
Loading

According to the discussion #7020 (comment).
FIX: #8263

TODO

  • Implement Idefics3
  • Add unit test
  • [ ] Add PP

@jeejeelee jeejeelee marked this pull request as draft October 28, 2024 15:57
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@jeejeelee
Init
dc48857 
Signed-off-by: Jee Jee Li <[email protected]>
@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 5, 2024
@jeejeelee jeejeelee marked this pull request as ready for review November 5, 2024 06:15
@jeejeelee
Update docs
84d7428 
Signed-off-by: Jee Jee Li <[email protected]>
Isotr0py
Isotr0py reviewed Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments about the idefics3 tests. :)

Will take a look to model implementation later.

tests/models/decoder_only/vision_language/test_idefics3.py Outdated Show resolved Hide resolved
tests/models/decoder_only/vision_language/test_idefics3.py Outdated Show resolved Hide resolved
Isotr0py
Isotr0py reviewed Nov 5, 2024
View reviewed changes
vllm/model_executor/models/idefics3.py Outdated Show resolved Hide resolved
vllm/model_executor/models/idefics3.py Outdated Show resolved Hide resolved
vllm/model_executor/models/idefics3.py Outdated Show resolved Hide resolved
vllm/model_executor/models/idefics3.py Outdated Show resolved Hide resolved
@jeejeelee
Copy link
Contributor Author

@Isotr0py Thanks for your review. We have modified these codes, please take another look, thank you very much

@mergify mergify bot added the frontend label Nov 6, 2024
@B-201
Fix code format
10415d3 
Signed-off-by: B-201 <[email protected]>
Isotr0py
Isotr0py approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests all passed locally, thanks for implementing this!

@Isotr0py Isotr0py enabled auto-merge (squash) November 6, 2024 08:09
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 6, 2024
@Isotr0py
Copy link
Collaborator

Isotr0py commented Nov 6, 2024

Seems that the registry failed due to Idefics3Config import, let me fix it by lazy import.

@jeejeelee
Copy link
Contributor Author

Seems that the registry failed due to Idefics3Config import, let me fix it by lazy import.

Maybe changing it to PretrainedConfig would be better?

@Isotr0py
Copy link
Collaborator

Isotr0py commented Nov 6, 2024 •
edited
Loading

Maybe changing it to PretrainedConfig would be better?

Sure, we can use from transformers import PretrainedConfig as Idefics3Config as a temporary solution. Can you please update the branch?

@jeejeelee
Fix model registry
e5bb291 
Signed-off-by: Jee Jee Li <[email protected]>
auto-merge was automatically disabled November 6, 2024 09:08

Head branch was pushed to by a user without write access

@Isotr0py Isotr0py enabled auto-merge (squash) November 6, 2024 09:10
@jeejeelee
Copy link
Contributor Author

Maybe changing it to PretrainedConfig would be better?

Sure, we can use from transformers import PretrainedConfig as Idefics3Config as a temporary solution. Can you please update the branch?

Done. We really appreciate for your review and guidance, thanks

@jeejeelee
Copy link
Contributor Author

It looks like there are network-related errors in CI. Should we consider forcing a merge? @DarkLight1337 @Isotr0py

@Isotr0py Isotr0py merged commit a5bba7d into vllm-project:main Nov 6, 2024
50 checks passed
kzawora-intel added a commit to HabanaAI/vllm-fork that referenced this pull request Nov 6, 2024
@kzawora-intel
Revert "[Model] Add Idefics3 support (vllm-project#9767)"
b52f9df 
This reverts commit a5bba7d.
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@jeejeelee @B-201 @JC1DA
[Model] Add Idefics3 support (vllm-project#9767)
9a8555a 
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: B-201 <[email protected]>
Co-authored-by: B-201 <[email protected]>
Signed-off-by: Loc Huynh <[email protected]>
@jeejeelee jeejeelee deleted the support-idefics3 branch November 11, 2024 16:51
@B-201 B-201 mentioned this pull request Nov 13, 2024
Open
@DarkLight1337 DarkLight1337 mentioned this pull request Nov 13, 2024
Open
84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Model]: Support for Idefics3 8B Llama3
3 participants
@jeejeelee @Isotr0py @B-201