[Misc] Add pynccl wrappers for all_gather and reduce_scatter #9432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
tlrmchlsmth
force-pushed
the
tms/pynccl_allgather_wrapper
branch
from
16db410 to
9c77424
Compare
tlrmchlsmth
requested review from
mgoin,
alexm-neuralmagic,
comaniac,
simon-mo,
robertgshaw2-neuralmagic,
WoosukKwon,
njhill,
LiuXiaoxuanPKU,
KuntaiDu,
DarkLight1337,
ywang96 and
zhuohan123
as code owners
mergify
bot
added
documentation
Signed-off-by: Tyler Michael Smith <[email protected]>
tlrmchlsmth
force-pushed
the
tms/pynccl_allgather_wrapper
branch
from
9c77424 to
26e61d5
Compare
tlrmchlsmth
added
ready
tlrmchlsmth
removed request for
mgoin,
comaniac,
LiuXiaoxuanPKU and
KuntaiDu
tlrmchlsmth
removed request for
njhill,
zhuohan123,
simon-mo,
DarkLight1337,
WoosukKwon,
alexm-neuralmagic,
robertgshaw2-neuralmagic and
ywang96
|
Sorry for the carnage -- ran into some issues trying to fix the DCO |
mfournioux
pushed a commit
to mfournioux/vllm
that referenced
this pull request
Nov 28, 2024
…oject#9432) Signed-off-by: Maxime Fournioux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pynccl wrappers for all_gather and reduce_scatter so we can use them in CUDA graphs.
In particular, Molmo and the new version of OLMo currently use all_gather, so these could be beneficial there.