-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[Hybrid] Pass kernel block size to builders #27753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hybrid] Pass kernel block size to builders #27753
Conversation
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Thomas Parnell <[email protected]>
b9528e1 to
7c7fab3
Compare
Signed-off-by: Thomas Parnell <[email protected]>
|
@heheda12345 This is ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Thomas Parnell <[email protected]>
|
@tdoublep my only concern is codex's comment. Other parts looks great. |
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
|
@heheda12345 The v1-test-attention (B200) job is failing but it looks unrelated (the container doesn't even start-up). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Thomas Parnell <[email protected]> Signed-off-by: soaringk <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Purpose
Solves #27264 and #26936
This PR makes two changes:
Test Plan
I'm using the following test script:
Which on main using
FLASH_ATTNproduces:and on main with
FLASHINFERproduces:Test Result
With this PR,
FLASH_ATTNproduces:and
FLASHINFERproduces:Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.