Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel] CUTLASS grouped gemm fp8 MoE kernel #13972

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

ElizaWszola
Copy link
Contributor

@ElizaWszola ElizaWszola commented Feb 27, 2025

CUTLASS implementation of fp8 MoE kernel.

Tested with

llm = LLM(model="nm-testing/DeepSeek-Coder-V2-Lite-Instruct-FP8",
          trust_remote_code=True,
          tensor_parallel_size=2,
 )

Benchmark (Deepseek V2 Lite, total time of 25 runs)

[--------------------------------------------------------------------------------------------------------- Quant Matmul ---------------------------------------------------------------------------------------------------------]
                                                                                                                                    |  triton_moe  |  triton_moe_cuda_graphs  |  grouped_gemm_moe  |  grouped_gemm_moe_cuda_graphs
1 threads: -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
      nm-testing/deepseekv2-lite, num_experts=64, topk=6, per_act_token=False per_out_ch=False, MKN=((1, 2048, 1408))               |      3.6     |            2.6           |         3.6        |               3.3            
      nm-testing/deepseekv2-lite, num_experts=64, topk=6, per_act_token=False per_out_ch=False, MKN=((4, 2048, 1408))               |      6.8     |            6.7           |         4.7        |               4.3            
      nm-testing/deepseekv2-lite, num_experts=64, topk=6, per_act_token=False per_out_ch=False, MKN=((8, 2048, 1408))               |     10.1     |           10.0           |         5.6        |               5.1            
      nm-testing/deepseekv2-lite, num_experts=64, topk=6, per_act_token=False per_out_ch=False, MKN=((16, 2048, 1408))              |     15.0     |           14.9           |         6.8        |               6.3            
      nm-testing/deepseekv2-lite, num_experts=64, topk=6, per_act_token=False per_out_ch=False, MKN=((32, 2048, 1408))              |     16.9     |           16.8           |         7.3        |               6.9            
      nm-testing/deepseekv2-lite, num_experts=64, topk=6, per_act_token=False per_out_ch=False, MKN=((64, 2048, 1408))              |     17.0     |           16.9           |         7.6        |               7.1            
      nm-testing/deepseekv2-lite, num_experts=64, topk=6, per_act_token=False per_out_ch=False, MKN=((128, 2048, 1408))             |      8.5     |            8.4           |         8.1        |               7.6            
      nm-testing/deepseekv2-lite, num_experts=64, topk=6, per_act_token=False per_out_ch=False, MKN=((256, 2048, 1408))             |      9.1     |            9.0           |         9.0        |               8.5            
      nm-testing/deepseekv2-lite, num_experts=64, topk=6, per_act_token=False per_out_ch=False, MKN=((512, 2048, 1408))             |     10.9     |           10.8           |        10.6        |              10.1          
(times are in ms)  

ElizaWszola and others added 30 commits December 6, 2024 14:36
Signed-off-by: ElizaWszola <[email protected]>
Signed-off-by: ElizaWszola <[email protected]>
Signed-off-by: ElizaWszola <[email protected]>
Signed-off-by: ElizaWszola <[email protected]>
Co-authored-by: Lucas Wilkinson <[email protected]>
Signed-off-by: ElizaWszola <[email protected]>
Signed-off-by: ElizaWszola <[email protected]>
Signed-off-by: ElizaWszola <[email protected]>
Signed-off-by: ElizaWszola <[email protected]>
Signed-off-by: ElizaWszola <[email protected]>
Signed-off-by: ElizaWszola <[email protected]>
Signed-off-by: ElizaWszola <[email protected]>
Signed-off-by: ElizaWszola <[email protected]>
Signed-off-by: ElizaWszola <[email protected]>
Signed-off-by: ElizaWszola <[email protected]>
Signed-off-by: ElizaWszola <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Feb 27, 2025
Copy link

mergify bot commented Feb 27, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @ElizaWszola.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant