Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to add special tokens to the matcher in XGrammar. #11060

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sjuxax
Copy link
Contributor

@sjuxax sjuxax commented Dec 10, 2024

Prevent XGrammar from attempting to match on special tokens. XGrammar throws the assertion on the C++ side if we send it a special token for acceptance, which crashes the whole engine. This fix uses XGrammar's tokenizer_info to skip over these tokens before we submit them and get crashed.

FIX #11044 ; see that issue for the original traceback.

There may be a better way to do this than just continuing over the last token while it's special, but this is sufficient to resolve the crash for me and I'm noticing no slowdown or additional issues in outputs. Thanks!

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Engine crashes with Pixtral-HF and xgrammar decoding
1 participant