Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torch.compile] add a flag to track batchsize statistics #11059

Merged
merged 8 commits into from
Dec 10, 2024

Conversation

youkaichao
Copy link
Member

@youkaichao youkaichao commented Dec 10, 2024

I find that #11031 only records the statistics from the engine level, which is not enough.

we need to record the forward batchsize for every model forward, including using cudagraph or not.

then we can have accurate statistics of batchsizes, and can optimize the shapes we want to compile.

Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Copy link
Collaborator

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea, and could be very useful when benchmarking serving benchmarks cc @robertgshaw2-neuralmagic @tlrmchlsmth

@youkaichao youkaichao enabled auto-merge (squash) December 10, 2024 20:04
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 10, 2024
@youkaichao youkaichao disabled auto-merge December 10, 2024 20:40
@youkaichao youkaichao merged commit 75f89dc into vllm-project:main Dec 10, 2024
56 of 62 checks passed
@youkaichao youkaichao deleted the track_bs branch December 10, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants