[Bugfix] Fix value unpack error of simple connector for KVCache transfer. #11058
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
send_kv_caches_and_hidden_states
get the value ofnum_heads
andhead_size
fromkv_cache[0].shape
, which will raise ValueError when the KVCache is compacted. Since we have model_executable as the function input, we can directly get these values from the model config to avoid this error. Also, we do not need to calculate this for every single layer, so we calculate this only once for all layers.For example,
when
kv_cache[0].shape == torch.Size([2162, 16, 40, 128])
, this line works normally,when
kv_cache[0].shape == torch.Size([2162, 81920])
, it will raise ValueError.CC list: @KuntaiDu @youkaichao