Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Support Lark grammars for XGrammar #10870

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

mgoin
Copy link
Collaborator

@mgoin mgoin commented Dec 3, 2024

Expands XGrammar to support "all" types of grammars that outlines supports so we can remove the fallback

Copy link

github-actions bot commented Dec 3, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin mgoin changed the title Support Lark grammars for XGrammar [Core] Support Lark grammars for XGrammar Dec 3, 2024
Copy link

mergify bot commented Dec 3, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @mgoin.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 3, 2024
@mgoin mgoin added ready ONLY add when PR is ready to merge/full CI is needed and removed needs-rebase labels Dec 3, 2024
Copy link

mergify bot commented Dec 5, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @mgoin.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 5, 2024
@mergify mergify bot removed the needs-rebase label Dec 5, 2024
Signed-off-by: mgoin <[email protected]>
@mgoin mgoin merged commit 8b59631 into vllm-project:main Dec 6, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants