Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model] support bitsandbytes quantization with minicpm model #10842

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[Model] support bitsandbytes quantization with minicpm model #10842

merged 1 commit into from
Dec 3, 2024
+10 −0

Conversation

zixuanzhang226
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

jeejeelee
jeejeelee approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , I assume you have verified it locally

@zixuanzhang226
Copy link
Contributor Author

LGTM , I assume you have verified it locally

Hello @jeejeelee, yes, I verified it locally.

@jeejeelee jeejeelee enabled auto-merge (squash) December 3, 2024 01:46
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 3, 2024
Isotr0py
Isotr0py approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also worked on openbmb/MiniCPM-2B-128k with tp=2.

@jeejeelee jeejeelee merged commit d746268 into vllm-project:main Dec 3, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@jeejeelee jeejeelee jeejeelee approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zixuanzhang226 @jeejeelee @Isotr0py