-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] add warning about comparing hf and vllm outputs #10805
Conversation
Signed-off-by: youkaichao <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: youkaichao <[email protected]>
Let's merge this first. Later we can implement #10758 |
oh i don't know #10758 . Is that what we want to implement? that's kind of bc-breaking. |
I would argue that #10758 is the "intended" behavior. To avoid breaking changes, we can log a warning for a while before finally switching over to using |
|
Let's move the discussion to that issue so we can gather thoughts from the OP as well. |
…0805) Signed-off-by: youkaichao <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
…0805) Signed-off-by: youkaichao <[email protected]> Signed-off-by: cedonley <[email protected]>
A lesson learned from #1069 (comment) .
In our ci, we always use
do_sample=False
for huggingface models, so it is not a problem.