merge queue: embarking main (129f873), #753 and #641 together - #770
Closed
mergify[bot] wants to merge 20 commits into
Closed
merge queue: embarking main (129f873), #753 and #641 together#770mergify[bot] wants to merge 20 commits into
mergify[bot] wants to merge 20 commits into
Conversation
Use CLI to construct a ProfileArgs instance, which is then used to build the Profile. Like datasets and backends, we now identify a profile "kind", as `--profile kind=constant[,param=value...]`; directly specified parameters supercede inherited global CLI values like `--rate`. Use more meaningful aliases for the global "rate" to match the previous internal names (e.g., "sweep_size"). This also exposes previously hidden parameters like the sweep's `strategy_type` to run poisson instead of constant async. Manually tested all profiles, including Replay. Assisted-by: Cursor Signed-off-by: David Butenhof <dbutenho@redhat.com>
- Remove Pydantic aspect of Profile class, holding a reference to ProfileArgs.
- Remove constraints from ProfileArgs, to isolate construction and remove some
report serialization issues.
- Change ProfileArgs deserialization to "forbid" unknown keys. We have two
classes of profile parameter that aren't "universal":
- data and data_samples are used only by Replay: we remove these from other
ProfileArgs -- this will be refactored later.
- Although random_seed isn't used by all profiles, it's a global used
throughout GuideLLM, so we promote this to the base ProfileArgs for
convenience.
Assisted-by: Cursor
Signed-off-by: David Butenhof <dbutenho@redhat.com>
- move random_seed to Profile - formalize abstraction of Profile with ABC Signed-off-by: David Butenhof <dbutenho@redhat.com>
Signed-off-by: David Butenhof <dbutenho@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
`torch` seems to break when it encounters lazy ImportErrors Signed-off-by: Samuel Monson <smonson@redhat.com>
Generated-by: claude-code Sonnet 4.6 Signed-off-by: Samuel Monson <smonson@redhat.com>
Generated-by: claude-code Sonnet 4.6 Signed-off-by: Samuel Monson <smonson@redhat.com>
This reverts commit e31862e. Signed-off-by: Samuel Monson <smonson@redhat.com>
Generated-by: claude-code Sonnet 4.6 Signed-off-by: Samuel Monson <smonson@redhat.com>
Generated-by: claude-code Sonnet 4.6 Signed-off-by: Samuel Monson <smonson@redhat.com>
Generated-by: claude-code Opus 4.6 Signed-off-by: Samuel Monson <smonson@redhat.com>
Generated-by: claude-code Opus 4.6 Signed-off-by: Samuel Monson <smonson@redhat.com>
Generated-by: claude-code Opus 4.6 Signed-off-by: Samuel Monson <smonson@redhat.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (129f873), #753 and #641 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #641.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:Merge Requirements]:check-success = quality (3.10) / type-checkscheck-neutral = quality (3.10) / type-checkscheck-skipped = quality (3.10) / type-checksMerge Requirements]:check-success = quality (3.10) / precommit-checkscheck-neutral = quality (3.10) / precommit-checkscheck-skipped = quality (3.10) / precommit-checksMerge Requirements]:check-success = quality (3.10) / quality-checkscheck-neutral = quality (3.10) / quality-checkscheck-skipped = quality (3.10) / quality-checksMerge Requirements]:check-success = tests (3.10) / e2e-testscheck-neutral = tests (3.10) / e2e-testscheck-skipped = tests (3.10) / e2e-testsMerge Requirements]:check-success = tests (3.10) / integration-testscheck-neutral = tests (3.10) / integration-testscheck-skipped = tests (3.10) / integration-testsMerge Requirements]:check-success = tests (3.10) / unit-testscheck-neutral = tests (3.10) / unit-testscheck-skipped = tests (3.10) / unit-testsMerge Requirements]:check-success = update-descriptioncheck-neutral = update-descriptioncheck-skipped = update-descriptionRequired conditions to stay in the queue:
#approved-reviews-by >= 1#changes-requested-reviews-by = 0-closed-draftcheck-success = DCOcheck-success = update-description