Skip to content

WIP: Multiturn Benchmarking Support #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: feat/unified_scheduler
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/guidellm/request/loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,13 +107,20 @@ def __init__(
self._preserved_iter = None

def __iter__(self) -> Iterator[GenerativeRequestSession]:
turns = 1

data_iter = self._create_requests()
while requests := [i for i, _ in zip(data_iter, range(turns))]:
yield GenerativeRequestSession(requests)

def _create_requests(self) -> Iterator[GenerationRequest]:
scope_create_count = 0

while (dataset_iter := self._get_dataset_iter(scope_create_count)) is not None:
scope_create_count += 1

for item in dataset_iter:
yield GenerativeRequestSession(self._create_request(item))
yield self._create_request(item)

self._preserved_iter = None

Expand Down
44 changes: 35 additions & 9 deletions src/guidellm/request/session.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import itertools
from abc import ABC, abstractmethod
from typing import Generic, TypeVar

Expand Down Expand Up @@ -29,24 +30,49 @@ def push_response(self, response: ResponseT) -> None: ...
def complete(self) -> bool: ...


# TODO: Implement multiturn support
# FIXME: Bad implementation. Can only handle string requests
class GenerativeRequestSession(RequestSession[GenerationRequest, ResponseSummary]):
def __init__(self, request: GenerationRequest) -> None:
self.request = request
self._complete = False
def __init__(self, prompts: list[GenerationRequest]) -> None:
if not prompts:
raise ValueError("Prompts cannot be empty")

self.prompts = prompts
self.responses: list[str] = []

def __len__(self) -> int:
return 1
return len(self.prompts)

def get_next_request(self) -> GenerationRequest:
return self.request
completed_responses = len(self.responses)
base_request = self.prompts[completed_responses].model_copy(deep=True)
base_request.content = "".join(
itertools.chain.from_iterable(
zip((x.content for x in self.prompts), self.responses + [""])
)
)
base_request.stats["prompt_tokens"] = sum(
x.stats["prompt_tokens"] for x in self.prompts[: completed_responses + 1]
)
base_request.constraints["output_tokens"] = sum(
x.constraints["output_tokens"]
for x in self.prompts[: completed_responses + 1]
)

return base_request

def get_next_delay(self) -> float:
return 0.0

def push_response(self, response: ResponseSummary) -> None: # noqa: ARG002
self._complete = True
def push_response(self, response: ResponseSummary) -> None:
if len(self.responses) < len(self.prompts):
if response.response_output_tokens is not None:
self.prompts[len(self.responses)].constraints["output_tokens"] = (
response.response_output_tokens
)
self.responses.append(response.value)
else:
raise ValueError("Response list full")

@property
def complete(self) -> bool:
return self._complete
return len(self.responses) >= len(self.prompts)
Loading