string: rename b to buf in string.replace_each to avoid sort lambda shadowing #26510
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shadowing In `replace_each()`, `idxs.sort(a.idx < b.idx)` uses `b` as the sort lambda parameter. The `mut b` declaration on the next line shadows it, causing the compiler to resolve `b` in the sort expression to the wrong variable, resulting in an access violation crash during code generation. Rename `b`/`b_i` to `buf`/`buf_i` to eliminate the name conflict. Co-Authored-By: Claude Opus 4.5 <[email protected]>
quaesitor-scientiam
changed the title
spytheman
approved these changes
Feb 3, 2026
Member
spytheman
left a comment
spytheman
left a comment
There was a problem hiding this comment.
Thank you @quaesitor-scientiam 🙇🏻 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
replace_each(),idxs.sort(a.idx < b.idx)usesbas the sort lambda parametermut bdeclaration on the next line shadows it, causing the compiler to resolvebin the sort expression to the wrong variableb/b_itobuf/buf_ito eliminate the name conflictTest plan
v test vlib/builtin/— 32 passed, 1 skipped, 0 failedreplace_each🤖 Generated with Claude Code