Skip to content

Conversation

@kbkpbot
Copy link
Contributor

@kbkpbot kbkpbot commented Jan 13, 2026

Turn implicit function declaration from warning to error.
This help fix issue such as #14783

@kbkpbot kbkpbot linked an issue Jan 13, 2026 that may be closed by this pull request
@kbkpbot kbkpbot marked this pull request as draft January 13, 2026 13:50
@spytheman
Copy link
Member

Imho that is not necessary.
V already supports -cstrict , which turns many other warnings into errors, including that specific one:
image

@kbkpbot
Copy link
Contributor Author

kbkpbot commented Jan 13, 2026

Because -cstrict is not on by default, so I think it is better add -Werror=implicit-function-declaration to compile options.
You can see in some CI fail, for example, the Build Vinix / vinix-build (pull_request), it has implicit declaration of function ‘mount’ .

@kbkpbot
Copy link
Contributor Author

kbkpbot commented Jan 13, 2026

CI fail https://github.com/vlang/v/actions/runs/20957079817/job/60224272531?pr=26343 is because vsql use flock which should include in #include <sys/file.h>, but https://github.com/elliotchance/vsql/blob/main/vsql/flock_nix.c.v use #include <fcntl.h>

https://github.com/elliotchance/vsql/blob/87910673dfdbdec246a9801983bbcea7db363472/vsql/flock_nix.c.v#L9C1-L11

I am not sure this repo is maintained or not....

@JalonSolov
Copy link
Contributor

Yes, vsql is maintained. Elliot is on the V discord... just posted something recently.

Make an issue for him on the vsql repo.

@kbkpbot
Copy link
Contributor Author

kbkpbot commented Jan 14, 2026

Yes, vsql is maintained. Elliot is on the V discord... just posted something recently.

Make an issue for him on the vsql repo.

Thank you. I post some issues at upstream, hope they can be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

u64 from C lost high part

3 participants