Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v: cleanup used_features logic from checker #23502

Merged
merged 7 commits into from
Jan 17, 2025

Conversation

felipensp
Copy link
Member

Cleanup

Copy link

Connected to Huly®: V_0.6-21931

@felipensp felipensp changed the title v: cleanup used_features logic from checker / added @[if skip_unused ?] v: cleanup used_features logic from checker Jan 17, 2025
@felipensp felipensp marked this pull request as ready for review January 17, 2025 22:38
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good cleanup 🥳.
Excellent work.

Comment on lines -15 to -17
if c.pref.skip_unused && decl_sym.mod == 'main' {
c.table.used_features.interfaces = true
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find, it is indeed unused currently

@spytheman spytheman merged commit 1b9f15d into vlang:master Jan 17, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants