Skip to content

fix: Move V installation out of current working directory#10

Merged
JalonSolov merged 6 commits intovlang:mainfrom
cadamsdev:issue-7
Mar 12, 2026
Merged

fix: Move V installation out of current working directory#10
JalonSolov merged 6 commits intovlang:mainfrom
cadamsdev:issue-7

Conversation

@cadamsdev
Copy link
Contributor

@cadamsdev cadamsdev commented Mar 5, 2026

Notable changes

  • Moved the V installation to the home directory instead of the current working directory.
  • Cleaned up the CI workflow
    • cache npm (faster npm ci)
    • use matrix strategies instead of separate jobs
    • updated version argument to 0.5.1
    • removed redundant use-latest-stable job

Fixes #9, #7, #6

Before

Screenshot 2026-03-04 at 10 38 51 PM

After

Screenshot 2026-03-04 at 10 38 23 PM

@JalonSolov
Copy link
Contributor

The CI is loading a positively "ancient" version of V, so that is likely the cause of the failure. The CI is also only using node 20, rather than something later... no idea if that's a problem or not.

Also, did you bump the version in your changes?

@cadamsdev
Copy link
Contributor Author

cadamsdev commented Mar 9, 2026

Hey @JalonSolov

The CI is loading a positively "ancient" version of V, so that is likely the cause of the failure.

I bumped it to the latest stable version "0.5". Hopefully that fixes it. 🤞

The CI is also only using node 20, rather than something later... no idea if that's a problem or not.

That shouldn't cause any issues. I'll create a separate PR to update the node version. 👍 We should use the latest Node LTS version (Node v24).

Also, did you bump the version in your changes?

We don't need to bump it. Just create/republish the major tag. Since these changes are backwards compatible, I recommend updating the v1 tag (common practice in GitHub Actions). No need for minor tags like v1.1, v1.2, etc.

@cadamsdev cadamsdev changed the title fix: Move V installation out of current working directory Fix move V installation out of current working directory Mar 9, 2026
@cadamsdev cadamsdev changed the title Fix move V installation out of current working directory fix: Move V installation out of current working directory Mar 9, 2026
@JalonSolov
Copy link
Contributor

V 0.5.1 was just released, so there is that.

Personally, I'd rather just use latest, since V still changes quite often, and even here we've just seen how anyone using this action was getting an "ancient" version because the CI wasn't being updated. :-\

@cadamsdev
Copy link
Contributor Author

cadamsdev commented Mar 10, 2026

V 0.5.1 was just released, so there is that.

Personally, I'd rather just use latest, since V still changes quite often

We can't use latest. The job requires us to pass in a specific version to test the version argument.

anyone using this action was getting an "ancient" version because the CI wasn't being updated. :-\

Users of this action won't get an "ancient" version of V. That only affects the workflow in this repo because the version was hardcoded to an older version. (This repo hasn't been updated in 2 years)

Here's the scenarios

If the version is not specified, the action uses v version 0.5.1

- name: Setup V
   uses: vlang/setup-v@v1.4

Setting check-latest uses v version 0.5.1

- name: Setup V
   uses: vlang/setup-v@v1.4
   with:
     check-latest: true

Setting stable uses v version 0.5.1

- name: Setup V
   uses: vlang/setup-v@v1.4
   with:
     stable: true

Setting check-latest and stable uses v version 0.5.1

- name: Setup V
   uses: vlang/setup-v@v1.4
   with:
     check-latest: true
     stable: true

Setting explicit version will use that version e.g

- name: Setup V
   uses: vlang/setup-v@v1.4
   with:
     version: weekly.2026.08

Uses v version weekly.2026.08

The action seems to be working correctly.

@cadamsdev cadamsdev mentioned this pull request Mar 10, 2026
@JalonSolov JalonSolov merged commit 0a679bf into vlang:main Mar 12, 2026
11 checks passed
@cadamsdev cadamsdev deleted the issue-7 branch March 12, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vlang folder removing

2 participants