Provide local fonts for TPF and Tenderfoot theme #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Apr 30, 2024
litvinovg
force-pushed
the
font-issue
branch
3 times, most recently
from
19d071a
to
213ff88
Compare
chenejac
previously approved these changes
May 7, 2024
There was a problem hiding this comment.
General comment
Thanks for this. I have ignored the first three commits in my review.
Testing
The localhost/vivo/tpf/core has been opened and code inspector in the google chrome is used to validate fonts from webjars directory have been loaded
Code reviewing
No complaints for the code (besides comment about need for webjars in the file path already stated in the #464
wwelling
previously approved these changes
May 23, 2024
chenejac
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO PR
What does this pull request do?
Added local fonts, fixed Triple Pattern Fragment template to use local fonts.
What's new?
Added webjar dependencies to provide:
Open Sans font, license Apache 2.0
https://mvnrepository.com/artifact/org.webjars.npm/npm-font-open-sans/1.1.0
Noto Sans font, license MIT
https://mvnrepository.com/artifact/org.webjars.npm/openfonts__noto-sans_all/1.44.0
How should this be tested?
Additional Notes:
Stacked on top of #464
Interested parties
@hauschke
Reviewers' expertise
Candidates for reviewing this PR should have some of the following expertises:
Reviewers' report template
General comment
A reviewer should provide here comments and suggestions for requested changes if any.
Testing
A reviewer should briefly describe here how it was tested
Code reviewing
A reviewer should briefly describe here which part was code reviewed