Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide local fonts for TPF and Tenderfoot theme #465

Merged
merged 2 commits into from
May 31, 2024

Conversation

litvinovg
Copy link
Contributor

@litvinovg litvinovg commented Apr 30, 2024

VIVO PR

What does this pull request do?

Added local fonts, fixed Triple Pattern Fragment template to use local fonts.

What's new?

Added webjar dependencies to provide:
Open Sans font, license Apache 2.0
https://mvnrepository.com/artifact/org.webjars.npm/npm-font-open-sans/1.1.0
Noto Sans font, license MIT
https://mvnrepository.com/artifact/org.webjars.npm/openfonts__noto-sans_all/1.44.0

How should this be tested?

  • Enable TPF by uncommenting tpf.activeFlag = true
  • Open TPF page /tpf/core , in web development tools check that local fonts are being downloaded.

Additional Notes:

Stacked on top of #464

Interested parties

@hauschke

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:

  1. Maven, web development

Reviewers' report template

General comment

A reviewer should provide here comments and suggestions for requested changes if any.

Testing

A reviewer should briefly describe here how it was tested

Code reviewing

A reviewer should briefly describe here which part was code reviewed

chenejac
chenejac previously approved these changes May 7, 2024
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment

Thanks for this. I have ignored the first three commits in my review.

Testing

The localhost/vivo/tpf/core has been opened and code inspector in the google chrome is used to validate fonts from webjars directory have been loaded

Code reviewing

No complaints for the code (besides comment about need for webjars in the file path already stated in the #464

wwelling
wwelling previously approved these changes May 23, 2024
@chenejac chenejac merged commit 33bf9a7 into vivo-project:main May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Google Fonts from TPF implementation Remove Google Fonts from Tenderfoot
3 participants