Override the Cache-Control header with no-cache for error responses
#692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
dkarnutsch,
fraxachun,
johnnyomair,
manuelblum and
nsams
manuelblum
previously approved these changes
Jan 27, 2025
thomasdax98
added
the
recommended-change
thomasdax98
commented
Jan 27, 2025
Comment on lines
+61
to
+65
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| // Reason: TS complains about passing unknown[] to writeHead, however explicit typing is complicated | ||
| // because writeHead can be overloaded and has two signatures | ||
| return originalWriteHead.apply(this, [statusCode, ...args]); |
There was a problem hiding this comment.
Passing the args as unknown[] to originalWriteHead causes the typescript error Type 'unknown' is not assignable to type 'OutgoingHttpHeaders | OutgoingHttpHeader[] | undefined'.. This only happens in the starter, it didn't happen in Demo.
Since writeHead can be overloaded and has two signatures, correct typing is hard. So I opted for just ignoring the error here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see Demo PR for more info: vivid-planet/comet#3269