Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for valid folderId #269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

juliawegmayr
Copy link
Contributor

@juliawegmayr juliawegmayr commented Jan 21, 2025

Add validation for folderId in the BrevoConfig to only allow entering ids, that actually exist.

Task: COM-1577

@juliawegmayr juliawegmayr changed the title Error messages for invalid folderId Add check for valid folderId Jan 21, 2025
@juliawegmayr juliawegmayr self-assigned this Jan 21, 2025
@juliawegmayr juliawegmayr reopened this Jan 23, 2025
@juliawegmayr juliawegmayr marked this pull request as ready for review January 23, 2025 09:50
@auto-assign auto-assign bot requested a review from raphaelblum January 23, 2025 09:50
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

this.contactsApi.setApiKey(Brevo.ContactsApiApiKeys.apiKey, apiKey);

// Limit set by Brevo
const limit = 50;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you only have 50 folders in total or is the limit restricted to 50?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The limit is restricted to 50 according to the documentation: https://developers.brevo.com/reference/getfolders-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants