-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow enable/disable speaker and microphone from UI #56
Conversation
Recommend to implement the functionality as Menu options. The button click behavior works correctly. Start with the following cmd line arguments |
Improvements in commit: [ab7a0b8] Merged the two functionalities into a single button -> Menu. Using command line arguments doesnt break the button. Only problem is the arguments code has been moved down in the main.py file to 151. I couldn't find a way to intialize the variable without altering the code structure a little bit. |
Improvements in commit: [2025a84] Removed the "Menu" button and added the enable/disable speaker/microphone to the edit button at top of the application. |
README.md
Outdated
@@ -104,7 +104,7 @@ Run ```generate_binary.bat``` file by replacing paths at the top of the file to | |||
|
|||
1. Download the zip file from | |||
``` | |||
https://drive.google.com/file/d/1UJR4rJt5umxxOiAHNGXPMhnnYr6Bj6fX/view?usp=sharing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming that the changes in the binary correspond to the changes in your branch.
If that is the case, binary should always be built from the main branch and you might have to rebuild the binary after this PR is merged to main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not updated the binaries according to changes in my branch.
Yes I'll rebuild the binaries after this PR is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no change to the binaries, the link should stay the same as before.
Solves issuse: #51 with commit: bff4eac
Addition of a new UI for enabling disabling microphone/speaker as per need.