Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Language Selection in UI #213

Merged
merged 4 commits into from
May 17, 2024
Merged

Clarify Language Selection in UI #213

merged 4 commits into from
May 17, 2024

Conversation

vivekuppal
Copy link
Owner

@vivekuppal vivekuppal commented May 16, 2024 •
edited
Loading

  • Distinguish between the two language selections for STT and LLM Response.
  • Audio can be in one language and responses can be in a different language.
  • Remember both language settings across application restart.
  • Enable utf-8 logging in db.log.
  • Allow LLM response interval to be configurable up to 30s in UI.

Resolves issue #52

j0n0w1ns
j0n0w1ns approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@j0n0w1ns j0n0w1ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change.
Lang parameter was confusing in the UI.

@vivekuppal vivekuppal merged commit 5992e6c into main May 17, 2024
5 checks passed
@vivekuppal vivekuppal mentioned this pull request May 17, 2024
Closed
@vivekuppal vivekuppal deleted the vu-2024-05-16 branch June 14, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0n0w1ns j0n0w1ns j0n0w1ns approved these changes

@Adarsha-gg Adarsha-gg Awaiting requested review from Adarsha-gg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vivekuppal @j0n0w1ns