Merge pull request #55 from Fastholf/add-crash-description

Pass ClassCastException to WrongViewFinderException
vivchar · Apr 8, 2021 · a8d8711 · a8d8711
2 parents dbea627 + b66ade5
commit a8d8711
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/...dapter/src/main/java/com/github/vivchar/rendererrecyclerviewadapter/BaseViewRenderer.java b/...dapter/src/main/java/com/github/vivchar/rendererrecyclerviewadapter/BaseViewRenderer.java
@@ -104,7 +104,7 @@ protected void bindInner(@NonNull final M model, @NonNull final VH holder, @NonN
             /* temporary workaround to catch ViewFinder ClassCastException,
              by some reason ViewHolder.getViewFinder() catch doesn't work */
             if (e.getMessage().contains(ViewFinder.class.getSimpleName())) {
-                throw new WrongViewFinderException();
+                throw new WrongViewFinderException(e);
             } else {
                 throw e;
             }

diff --git a/...rviewadapter/src/main/java/com/github/vivchar/rendererrecyclerviewadapter/ViewHolder.java b/...rviewadapter/src/main/java/com/github/vivchar/rendererrecyclerviewadapter/ViewHolder.java
@@ -29,7 +29,7 @@ public VF getViewFinder() {
 			try {
 				mViewFinder = (VF) ViewFinderFactory.create(itemView);
 			} catch (ClassCastException e) { //TODO vivchar: by some reason it does not catch
-				throw new WrongViewFinderException();
+				throw new WrongViewFinderException(e);
 			}
 		}
 		return mViewFinder;

diff --git a/...rc/main/java/com/github/vivchar/rendererrecyclerviewadapter/WrongViewFinderException.java b/...rc/main/java/com/github/vivchar/rendererrecyclerviewadapter/WrongViewFinderException.java
@@ -1,14 +1,17 @@
 package com.github.vivchar.rendererrecyclerviewadapter;
 
+import androidx.annotation.NonNull;
+
 /**
  * Created by Vivchar Vitaly on 11.07.19.
  */
 
 public class WrongViewFinderException extends RuntimeException {
 
-    public WrongViewFinderException() {
+    public WrongViewFinderException(@NonNull final ClassCastException e) {
         super("Looks like you are trying to use a custom ViewFinder, " +
-                "but forgot to implement or register it, " +
-                "please use RendererRecyclerViewAdapter.registerViewFinder() to support your custom ViewFinder.");
+                "but forgot to implement or register it. As a result you've got the following error:" +
+                " \"" + e.getMessage() + "\". " +
+                "Please use RendererRecyclerViewAdapter.registerViewFinder() to support your custom ViewFinder.");
     }
 }