Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add popular projects to ecosystem-ci #15

Merged
merged 9 commits into from
Apr 30, 2024

Conversation

sheremet-va
Copy link
Member

No description provided.

Copy link

stackblitz bot commented Apr 25, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sheremet-va
Copy link
Member Author

@AriPerkkio is it possible to run them here before merging?

@sheremet-va
Copy link
Member Author

Hm, @AriPerkkio excalidraw should work fine 🤔 I don't understand why it's failing :(

@AriPerkkio
Copy link
Member

AriPerkkio commented Apr 26, 2024

Hm, @AriPerkkio excalidraw should work fine 🤔 I don't understand why it's failing :(

I've been looking into this and don't really know what's going on. Corepack (?) seems to be throwing error Usage Error: This project is configured to use pnpm, even with following changes:

export async function test(options: RunOptions) {
	await runInRepo({
		...options,
		branch: 'master',
		repo: 'excalidraw/excalidraw',
		test: 'test:app',
+		agent: "yarn",
	})
}

I think we need to ask vite-ecosystem-ci maintainers for help. It might be good to move excalidraw to separate PR and merge this one without it.

@AriPerkkio
Copy link
Member

excalidraw doesn't have packageManager defined in package.json. This command fails:

: await $`${pm} --version`

@AriPerkkio
Copy link
Member

AriPerkkio commented Apr 27, 2024

https://github.com/vitest-dev/vitest-ecosystem-ci/actions/runs/8867033024/job/24345137287

ENOENT: no such file or directory, stat '/home/runner/work/vitest-ecosystem-ci/vitest-ecosystem-ci/workspace/excalidraw/excalidraw/node_modules/vite-node/node_modules/vite'

@sheremet-va sheremet-va merged commit d27b168 into main Apr 30, 2024
2 of 3 checks passed
@sheremet-va sheremet-va deleted the feat/add-popular-projects branch April 30, 2024 09:24
@sheremet-va
Copy link
Member Author

effect is failing, but they are aware of the issue, and it should be fixed soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants