-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTAdmin: Show Hostname Alongside Tablet ID on tablet selection drop-downs #17982
VTAdmin: Show Hostname Alongside Tablet ID on tablet selection drop-downs #17982
Conversation
Signed-off-by: “niladrix719” <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
I think this is a very useful change! 👍 |
Signed-off-by: “niladrix719” <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested this locally as well.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17982 +/- ##
==========================================
+ Coverage 67.55% 67.58% +0.02%
==========================================
Files 1597 1598 +1
Lines 259907 260084 +177
==========================================
+ Hits 175586 175770 +184
+ Misses 84321 84314 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Added hostname alongside tablet Id on VTAdmin tablet selection drop-downs
Related Issue(s)
Fixes #17954
Checklist
Deployment Notes