Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTAdmin: Show Hostname Alongside Tablet ID on tablet selection drop-downs #17982

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

niladrix719
Copy link
Contributor

@niladrix719 niladrix719 commented Mar 18, 2025

Description

Added hostname alongside tablet Id on VTAdmin tablet selection drop-downs

  • using a different text style for the hostname to improve readability
  • displaying 'Unknown' when the hostname is missing

Screenshot 2025-03-18 at 8 13 00 PM

Related Issue(s)

Fixes #17954

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Mar 18, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 18, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Mar 18, 2025
@niladrix719 niladrix719 changed the title VTAdmin: Show Hostname Alongside Tablet ID in Dropdown VTAdmin: Show Hostname Alongside Tablet ID on VTAdmin tablet selection drop-downs Mar 18, 2025
@niladrix719 niladrix719 changed the title VTAdmin: Show Hostname Alongside Tablet ID on VTAdmin tablet selection drop-downs VTAdmin: Show Hostname Alongside Tablet ID on tablet selection drop-downs Mar 19, 2025
@arthurschreiber
Copy link
Contributor

I think this is a very useful change! 👍

Signed-off-by: “niladrix719” <[email protected]>
@beingnoble03 beingnoble03 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 20, 2025
Copy link
Member

@beingnoble03 beingnoble03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested this locally as well.

@beingnoble03 beingnoble03 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VTAdmin VTadmin interface labels Mar 20, 2025
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.58%. Comparing base (4a0513f) to head (6725f14).
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17982      +/-   ##
==========================================
+ Coverage   67.55%   67.58%   +0.02%     
==========================================
  Files        1597     1598       +1     
  Lines      259907   260084     +177     
==========================================
+ Hits       175586   175770     +184     
+ Misses      84321    84314       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@notfelineit notfelineit merged commit 1de4855 into vitessio:main Mar 28, 2025
109 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface Component: web UI Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: show hostname next to table id on VTAdmin tablet selection dropdowns
4 participants