Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundled MySQL version to 8.0.40 #17552

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dbussink
Copy link
Contributor

We haven't updated the bundled MySQL version in a while and it also blocks us from upgrading our base Debian version for the containers we build as well.

So update to the latest 8.0.x version here. It's also at least version 8.0.35, which means that updates after this one are going to be much easier as upgrades / downgrades between different patch versions are possible for 8.0.35 and later.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Jan 16, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 16, 2025
We haven't updated the bundled MySQL version in a while and it also
blocks us from upgrading our base Debian version for the containers we
build as well.

So update to the latest 8.0.x version here. It's also at least version
8.0.35, which means that updates after this one are going to be much
easier as upgrades / downgrades between different patch versions are
possible for 8.0.35 and later.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/update-mysql-8-0-40 branch from 9e82bb4 to 220dcfd Compare January 16, 2025 08:57
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 16, 2025
@dbussink dbussink mentioned this pull request Jan 16, 2025
5 tasks
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.69%. Comparing base (5468f5d) to head (220dcfd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17552      +/-   ##
==========================================
- Coverage   67.70%   67.69%   -0.02%     
==========================================
  Files        1584     1584              
  Lines      254718   254718              
==========================================
- Hits       172463   172431      -32     
- Misses      82255    82287      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GrahamCampbell
Copy link
Contributor

I've created planetscale/vitess-operator#653 which applies upgrades to the operator. Feel free to throw it away if you had other plans. ;)

Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update this:
examples/operator/101_initial_cluster.yaml: mysql80Compatible: mysql:8.0.30

@frouioui are you already coordinating with @dbussink on this? As you both know, it will span many PRs across several repos 🙂 Let me know if you could use any help.


#### <a id="upgrading-to-this-release-with-vitess-operator"/>⚠️Upgrading to this release with vitess-operator

If you are using the `vitess-operator` and want to remain on MySQL 5.7, **you are required** to use the `vitess/lite:v16.0.0-mysql57` Docker Image, otherwise the `vitess/lite:v16.0.0` image will be on MySQL 80.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be v16 should it? Same thing below.

I think that we can remove this section entirely since we do not have 5.7 images in v21 or v22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build/CI NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says Type: CI/Build Type: Dependencies Dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants