Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-21.0] Use proper groupId for mysql connector in java (#17540) #17541

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jan 15, 2025

Description

This is a backport of #17540

@vitess-bot vitess-bot bot added Backport This is a backport Component: Java Pull requests that update Java code Merge Conflict Skip CI Skip CI actions from running Type: Bug labels Jan 15, 2025
Copy link
Contributor Author

vitess-bot bot commented Jan 15, 2025

Hello @frouioui, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 17541 -R vitessio/vitess
git reset --hard origin/release-21.0
git cherry-pick -m 1 8e905aaf740ba7037e0dacbc3d4b1c09a23353d1

@vitess-bot vitess-bot bot requested a review from dbussink January 15, 2025 17:28
Copy link
Contributor Author

vitess-bot bot commented Jan 15, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v21.0.2 milestone Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.52%. Comparing base (f039622) to head (4e340af).
Report is 1 commits behind head on release-21.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-21.0   #17541      +/-   ##
================================================
- Coverage         67.53%   67.52%   -0.01%     
================================================
  Files              1570     1570              
  Lines            251468   251468              
================================================
- Hits             169818   169808      -10     
- Misses            81650    81660      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To unblock once the fix is pushed.

@frouioui frouioui removed Skip CI Skip CI actions from running Merge Conflict labels Jan 15, 2025
@frouioui frouioui force-pushed the backport-17540-to-release-21.0 branch from 3042446 to 0286d5c Compare January 15, 2025 20:36
@frouioui frouioui marked this pull request as ready for review January 15, 2025 21:27
@frouioui
Copy link
Member

I ended up backporting #17542 in this Pull Request too. The work done in #17542 complements the original code that this PR backports.

@frouioui frouioui merged commit c4a4908 into release-21.0 Jan 15, 2025
195 checks passed
@frouioui frouioui deleted the backport-17540-to-release-21.0 branch January 15, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport This is a backport Component: Java Pull requests that update Java code Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants