Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Online DDL forced cut-over: terminate transactions holding metadata locks on table #17535

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Online DDL forced cut-over: terminate transactions holding metadata locks on table #17535

wants to merge 7 commits into from
+173 −43

Conversation

shlomi-noach
Copy link
Contributor

Description

Followup to #14546
This PR complements #14546 by also addressing transactions that are holding metadata locks on the migrated table (as seen in performance_schema.metadata_locks starting MySQL 8.0.2).

Added an endtoend test that validated forced termination.

Related Issue(s)

#14530

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) labels Jan 15, 2025
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 15, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 15, 2025
@shlomi-noach shlomi-noach requested a review from a team January 15, 2025 14:10
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 15, 2025
@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 15, 2025
@shlomi-noach shlomi-noach marked this pull request as draft January 15, 2025 14:13
@shlomi-noach
filter by object_name
3729cca 
Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach shlomi-noach marked this pull request as ready for review January 15, 2025 14:14
@shlomi-noach
empty commit to kick CI
367eb63 
Signed-off-by: Shlomi Noach <[email protected]>
rohit-nayak-ps
rohit-nayak-ps reviewed Jan 15, 2025
View reviewed changes
go/vt/vttablet/onlineddl/executor.go Outdated
rs, err := conn.Conn.ExecuteFetch(query, -1, true)
if err != nil {
return vterrors.Wrapf(err, "finding transactions locking table")
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe extract out into a common function and pass in the capability and query for the two cases?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. They seem identical other than the capability and query so we could pass both into a function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

mattlord
mattlord approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Just the two nits about a shared function and the mysqlgr flavor file.

go/vt/vttablet/onlineddl/executor.go Outdated
rs, err := conn.Conn.ExecuteFetch(query, -1, true)
if err != nil {
return vterrors.Wrapf(err, "finding transactions locking table")
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. They seem identical other than the capability and query so we could pass both into a function.

go/mysql/flavor_mysqlgr_test.go Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 6.45161% with 29 lines in your changes missing coverage. Please review.

Project coverage is 67.69%. Comparing base (301c92c) to head (15fc084).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/onlineddl/executor.go 0.00% 29 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #17535   +/-   ##
=======================================
  Coverage   67.68%   67.69%           
=======================================
  Files        1584     1584           
  Lines      254717   254726    +9     
=======================================
+ Hits       172417   172431   +14     
+ Misses      82300    82295    -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattlord
Copy link
Contributor

You'll have to merge in origin/main to get the fixes in #17540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@mattlord mattlord mattlord approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) NeedsWebsiteDocsUpdate What it says Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shlomi-noach @mattlord @rohit-nayak-ps