Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtadmin: enable sorting in all tables #17468

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

c-r-dev
Copy link
Contributor

@c-r-dev c-r-dev commented Jan 6, 2025

Description

vtadmin: enable table sorting, for the schemas table to sort by size / rows.

SortingDemo

Related Issue(s)

Fixes #14153

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Creating this PR as draft mode , introduced new SortedDataTable (inline with DataTable + some logic. on columns being sortable).

  • Open for ideas on refactoring , and also would like to know if the UI changes have a std test pack to be run.

  • Tested these changes locally.

Copy link
Contributor

vitess-bot bot commented Jan 6, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 6, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 6, 2025
Signed-off-by: c-r-dev <[email protected]>
@c-r-dev c-r-dev marked this pull request as ready for review January 7, 2025 18:24
@c-r-dev c-r-dev marked this pull request as draft January 14, 2025 01:02
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.69%. Comparing base (8ba7607) to head (431ad9f).
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17468      +/-   ##
==========================================
+ Coverage   67.67%   67.69%   +0.02%     
==========================================
  Files        1584     1584              
  Lines      254368   254721     +353     
==========================================
+ Hits       172139   172445     +306     
- Misses      82229    82276      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepthi deepthi added Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature) and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 15, 2025
@c-r-dev
Copy link
Contributor Author

c-r-dev commented Jan 16, 2025

@jfontan , thanks for sharing sample UI Vitest file on slack , with 431ad9f made a UI test case. Please help to review and suggest additions if any.

@c-r-dev c-r-dev marked this pull request as ready for review January 16, 2025 16:00
@jfontan
Copy link
Contributor

jfontan commented Jan 16, 2025

@jfontan , thanks for sharing sample UI Vitest file on slack , with 431ad9f made a UI test case. Please help to review and suggest additions if any.

I believe you pinged the wrong user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vtadmin: enable sorting in all tables
3 participants