-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all durability policy names constants #17448
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17448 +/- ##
==========================================
- Coverage 67.67% 67.67% -0.01%
==========================================
Files 1583 1584 +1
Lines 254363 254386 +23
==========================================
+ Hits 172140 172151 +11
- Misses 82223 82235 +12 ☔ View full report in Codecov by Sentry. |
@@ -26,6 +26,7 @@ import ( | |||
|
|||
"vitess.io/vitess/go/mysql/sqlerror" | |||
"vitess.io/vitess/go/protoutil" | |||
"vitess.io/vitess/go/vt/vtctl/reparentutil" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GuptaManan100 Is this a lightweight package so that we don't end up including a large dependency chain in all places we add this to? That could increase potentially binary and / or compile times or makes parts harder to use as a library (if we do that for any of these bits really).
In the past I've always checked this and also sometimes explicitly opted for a new package then just with the contants to mitigate problems mentioned above.
Description
This PR makes the durability policy names constants and uses them everywhere. This makes the code more clean.
Related Issue(s)
Checklist
Deployment Notes