Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linearizable support to SQL VSchema management #17401

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Dec 17, 2024

Description

This PR prevents lost writes when using the VTGate SQL API for VSchema management (see issue).

It also lays the foundation for supporting linearizability guarantees for vschemas within Vitess. Please see the tracking issue for the other known pieces.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Dec 17, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 17, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Dec 17, 2024
@mattlord mattlord force-pushed the vschema_topo_version branch 4 times, most recently from 4b4578d to be1ccd1 Compare December 18, 2024 22:11
@mattlord mattlord added Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) and removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 18, 2024
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord force-pushed the vschema_topo_version branch from be1ccd1 to b2e2ba6 Compare December 19, 2024 22:21
@mattlord mattlord force-pushed the vschema_topo_version branch 2 times, most recently from e9319d3 to 1ccc129 Compare January 6, 2025 21:46
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord force-pushed the vschema_topo_version branch from 1ccc129 to e02adaf Compare January 6, 2025 22:48
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 65 lines in your changes missing coverage. Please review.

Project coverage is 67.70%. Comparing base (71ccd6d) to head (d8c9c53).

Files with missing lines Patch % Lines
go/vt/vtctl/vtctl.go 31.25% 22 Missing ⚠️
go/vt/vtgate/executorcontext/vcursor_impl.go 60.00% 8 Missing ⚠️
go/cmd/vtcombo/cli/vschema_watcher.go 0.00% 7 Missing ⚠️
go/vt/topotools/vschema_ddl.go 86.04% 6 Missing ⚠️
go/vt/vtcombo/tablet_map.go 0.00% 5 Missing ⚠️
go/vt/topo/vschema.go 90.00% 4 Missing ⚠️
go/vt/vtctl/grpcvtctldserver/server.go 85.71% 4 Missing ⚠️
go/vt/vtgate/vschema_manager.go 55.55% 4 Missing ⚠️
go/vt/topo/helpers/copy.go 33.33% 2 Missing ⚠️
go/test/utils/diff.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17401      +/-   ##
==========================================
- Coverage   67.71%   67.70%   -0.02%     
==========================================
  Files        1584     1584              
  Lines      254721   254799      +78     
==========================================
+ Hits       172473   172499      +26     
- Misses      82248    82300      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This reverts commit cd455a0.

Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Jan 14, 2025
@mattlord mattlord changed the title Add linearizable support to VSchema management Add linearizable support to SQL VSchema management Jan 14, 2025
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord force-pushed the vschema_topo_version branch 6 times, most recently from e1122ea to 1e3a496 Compare January 15, 2025 00:34
@mattlord mattlord force-pushed the vschema_topo_version branch from 1e3a496 to f5c6c63 Compare January 15, 2025 01:29
Signed-off-by: Matt Lord <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
1 participant