-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linearizable support to SQL VSchema management #17401
Open
mattlord
wants to merge
13
commits into
vitessio:main
Choose a base branch
from
planetscale:vschema_topo_version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,035
−540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 17, 2024
mattlord
force-pushed
the
vschema_topo_version
branch
4 times, most recently
from
December 18, 2024 22:11
4b4578d
to
be1ccd1
Compare
mattlord
added
Component: Query Serving
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
and removed
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Dec 18, 2024
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
vschema_topo_version
branch
from
December 19, 2024 22:21
be1ccd1
to
b2e2ba6
Compare
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
vschema_topo_version
branch
2 times, most recently
from
January 6, 2025 21:46
e9319d3
to
1ccc129
Compare
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
vschema_topo_version
branch
from
January 6, 2025 22:48
1ccc129
to
e02adaf
Compare
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17401 +/- ##
==========================================
- Coverage 67.71% 67.70% -0.02%
==========================================
Files 1584 1584
Lines 254721 254799 +78
==========================================
+ Hits 172473 172499 +26
- Misses 82248 82300 +52 ☔ View full report in Codecov by Sentry. |
This reverts commit cd455a0. Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
mattlord
removed
the
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
label
Jan 14, 2025
mattlord
changed the title
Add linearizable support to VSchema management
Add linearizable support to SQL VSchema management
Jan 14, 2025
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
vschema_topo_version
branch
6 times, most recently
from
January 15, 2025 00:34
e1122ea
to
1e3a496
Compare
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
vschema_topo_version
branch
from
January 15, 2025 01:29
1e3a496
to
f5c6c63
Compare
Signed-off-by: Matt Lord <[email protected]>
mattlord
requested review from
rohit-nayak-ps,
deepthi,
harshit-gangal,
systay,
shlomi-noach,
timvaillancourt,
GuptaManan100,
frouioui,
ajm188 and
notfelineit
as code owners
January 15, 2025 02:42
mattlord
removed request for
shlomi-noach,
timvaillancourt,
ajm188,
notfelineit and
rohit-nayak-ps
January 15, 2025 02:42
Signed-off-by: Matt Lord <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Query Serving
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents lost writes when using the VTGate SQL API for VSchema management (see issue).
It also lays the foundation for supporting linearizability guarantees for vschemas within Vitess. Please see the tracking issue for the other known pieces.
Related Issue(s)
Checklist