docs: note url string must be static #7508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5558
Additional context
Something I've been thinking about is if we can replace
import.meta.url
asself.location.href
everywhere to avoid issues like this, similar to #7464. This could be done in esbuild if the target is a browser, and it might help #5270 too.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).