Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix client and overlay modules for HMR on web workers.
This PR will be on draft since I need to add some test and what to do on
clearErrorOverlay
, line 200 ofclient.ts
.I just push it if anyone can review the changes on
packages/vite/src/client
.I've included on worker playground 2 examples to update
msg
fromworkerImport
module, also modified theindex.html
page to log HMR updates formy-worker
(normal and inlined),possible-ts-output-worker
andworkerImport
to avoid full reload.Here you can check the HMR working with playground web workers: https://streamable.com/0gtb8d
closes #25
closes #5396
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).