docs: mention bun.lock for lockfile
#20210
Conversation
| @@ -70,7 +70,7 @@ You can further customize esbuild too with the [`optimizeDeps.esbuildOptions` op | |||
|
|
|||
| Vite caches the pre-bundled dependencies in `node_modules/.vite`. It determines whether it needs to re-run the pre-bundling step based on a few sources: | |||
|
|
|||
| - Package manager lockfile content, e.g. `package-lock.json`, `yarn.lock`, `pnpm-lock.yaml` or `bun.lockb`. | |||
| - Package manager lockfile content, e.g. `package-lock.json`, `yarn.lock`, `pnpm-lock.yaml`, `bun.lock` or `bun.lockb`. | |||
There was a problem hiding this comment.
| - Package manager lockfile content, e.g. `package-lock.json`, `yarn.lock`, `pnpm-lock.yaml`, `bun.lock` or `bun.lockb`. | |
| - Package manager lockfile content, e.g. `package-lock.json`, `yarn.lock`, `pnpm-lock.yaml` or `bun.lock` |
Since this list is just an example, I think it's fine to remove bun.lockb because bun.lock has been added instead.
There was a problem hiding this comment.
In that case, this PR is irrelevant because it's just an example. Either keep both or close this PR in my opinion
There was a problem hiding this comment.
@sapphi-red , @WarningImHack3r , with respect I want to tell one thing if you allow. I have seen in the codebase that both bun.lock and bun.lockb are present. Can't we add both here also then ?
vite/packages/vite/src/node/optimizer/index.ts
Line 1231 in 3bf3a8a
There was a problem hiding this comment.
Having both feels too verbose. Since bun.lock is the new default for bun, I think bun.lock should be listed instead of bun.lockb.
There was a problem hiding this comment.
I see. Thank you for your opinion, @sapphi-red .
bun generates
bun.lockby default from bun v1.2. I think may be here we may addbun.lockwithbun.lockbas well.https://bun.sh/docs/install/lockfile