Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix rendering issues in mermaid JS diagrams #18731

Merged
merged 1 commit into from
Nov 21, 2024
Merged

docs: fix rendering issues in mermaid JS diagrams #18731

merged 1 commit into from
Nov 21, 2024
+60 −22

Conversation

kitsune7
Copy link
Contributor

Description

This updates the two Mermaid JS diagrams in CONTRIBUTING.md that fail to render new lines and Markdown lists appropriately.

Issue Triaging Workflow

Before:
Issue diagram

After:
Issue diagram fixed

Pull Request Review Workflow

Before:
PR diagram

After:
PR diagram fixed

@kitsune7 kitsune7 changed the title Fix rendering issues in mermaid JS diagrams docs: fix rendering issues in mermaid JS diagrams Nov 21, 2024
patak-dev
patak-dev approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I didn't know this was rendering so badly! Thanks a ton @kitsune7!

@patak-dev patak-dev merged commit c45576a into vitejs:main Nov 21, 2024
11 of 12 checks passed
@kitsune7 kitsune7 deleted the kitsune7/patch-4684 branch November 21, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitsune7 @patak-dev