feat: show more info on server start #18721
Open
+77
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nozomuikuta
commented
Nov 20, 2024
| @@ -158,19 +159,31 @@ export function createLogger( | |||
| return logger | |||
| } | |||
|
|
|||
| export function printServerUrls( | |||
| export function printServerInfo( | |||
There was a problem hiding this comment.
The name printServerInfo might no longer represent what it does.
Do you come up with any good name?
nozomuikuta
commented
Nov 20, 2024
| @@ -158,19 +159,31 @@ export function createLogger( | |||
| return logger | |||
| } | |||
|
|
|||
| export function printServerUrls( | |||
| export function printServerInfo( | |||
There was a problem hiding this comment.
IMO, we don't have to have a dedicated shortcut to show loaded env files and it's fine to print them with other info on server start and on demand.
What do you think?
There was a problem hiding this comment.
we could also print them indeed, maybe a shortcut is overengineered
nozomuikuta
commented
Nov 20, 2024
Comment on lines
281
to
+284
| /** | ||
| * Print server urls | ||
| * Print server info | ||
| */ | ||
| printUrls(): void | ||
| printInfo(): void |
There was a problem hiding this comment.
Should I keep deprecated property in documentation?
|
i'm grateful for this PR, i hope it lands soon. thanks a ton @nozomuikuta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #18719
DevServer.printUrlsandPreviewServer.printUrls.DevServer.printInfoandPreviewServer.printInfomodeand loaded env file names on server startI created this PR for
v5branch, but technically it can be applied tomainbranch too.