Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(create-vite): change directory structure of template-vanilla for consistency #18716

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(create-vite): change directory structure of template-vanilla for consistency #18716

wants to merge 1 commit into from
+1 −1

Conversation

nozomuikuta
Copy link
Contributor

@nozomuikuta nozomuikuta commented Nov 20, 2024 •
edited
Loading

Description

No related issues.
Maybe related to #16183.

I found that template-vanilla doesn't have src directory while the other templates do, and I didn't find any technical necessity for it to be like that.

This PR is just to make templates directory structure consistent.

Note that I added ! in the commit message (PR title) because I guess this change is a breaking one.

@nozomuikuta nozomuikuta changed the title chore(create-vite)!: move files into src directory for consistency chore(create-vite)!: change directory structure of template-vanilla for consistency Nov 20, 2024
bluwy
bluwy approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me 👍 It has also always irked me a bit. I don't think this would be considered a breaking change though so the ! can be removed.

@nozomuikuta nozomuikuta changed the title chore(create-vite)!: change directory structure of template-vanilla for consistency chore(create-vite): change directory structure of template-vanilla for consistency Nov 20, 2024
@nozomuikuta
Copy link
Contributor Author

@bluwy
Thank you for the review!
I just removed the ! mark from the commit message👍

@sapphi-red
Copy link
Member

The reason was to show case the most minimal project structure.

I thought the same, but looks like the vanilla template without ts was left flat to further show the most barebone possible structure.
#8478 (comment)

That said, I'm personally fine with making it consistent.

@sapphi-red sapphi-red added feat: create-vite create-vite package p2-nice-to-have Not breaking anything but nice to have (priority) labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
feat: create-vite create-vite package p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nozomuikuta @sapphi-red @bluwy