Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vite build now works with broken symlink in public #18592

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

fix: vite build now works with broken symlink in public #18592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/vite/src/node/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,6 +598,10 @@ export function copyDir(srcDir: string, destDir: string): void {
continue
}
const destFile = path.resolve(destDir, file)
// This may occur if the source directory is a symlink that points to a non-existent directory
if (!fs.existsSync(destFile)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be

Suggested change
if (!fs.existsSync(destFile)) {
if (!fs.existsSync(srcFile)) {

Also I think it'd nice to avoid this existsSync call and add an try-catch to fs.statSync instead. fs.statSync throwed ENOENT on my machine (both Windows and WSL), did fs.statSync return a result on your machine?

return
}
const stat = fs.statSync(srcFile)
if (stat.isDirectory()) {
copyDir(srcFile, destFile)
Expand Down
Loading