feat: support resolve.alias per environment in Environment API

[lazarv]

Description

This PR implements the suggested solution in #17582 and adds a test playground named environment-alias to check that the new alias plugin is using the resolve.alias specified per environment.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[patak-dev]

There are errors because the formatter wasn't run. It should be automatic when you commit. But you can run it manually if not.

We have a lot of playgrounds already, so we should try to avoid new ones as much as possible. Maybe you could try adding the test to the environment-react-ssr playground? Maybe later on we can have a more generic one for these tests.

[patak-dev]

This should be environment.options.resolve.alias, the config has the default values. We were thinking that we should deprecate these defaults on the ResolvedConfig and remove them later to avoid these issues.

[lazarv]

I kept this as a fallback and collecting the environment specific resolve.alias in the plugin, but if it's not needed, I can change this to pass it directly. Makes total sense as this part is creating a plugin container for the environment.

[patak-dev]

Ah, I see the new alias plugin. I think we don't need it. We can use the option here and keep everything else as is.

[lazarv]

I created the new plugin to work with resolve.alias out of the box. If you advise against that, then check my latest change. I changed the test to be a unit test and it's only using createIdResolver, but the consumer needs to handle the environment alias resolution using a custom plugin to make it work, check comment at #17583 (comment).

[lazarv]

There are errors because the formatter wasn't run. It should be automatic when you commit. But you can run it manually if not.

I only see that the deadlock test is failing, which was failing before my changes too and also locally, but I will re-check the formatter.

We have a lot of playgrounds already, so we should try to avoid new ones as much as possible. Maybe you could try adding the test to the environment-react-ssr playground? Maybe later on we can have a more generic one for these tests.

I will give it a go, probably I can integrate these tests into that playground.

[lazarv]

Re-run pnpm format, but no new changes. Could you please give me a link to the error?

[patak-dev]

Re-run pnpm format, but no new changes. Could you please give me a link to the error?

Ah, sorry for the noise. Format is ok, nvm that.

[hi-ogawa]

We have a lot of playgrounds already, so we should try to avoid new ones as much as possible. Maybe you could try adding the test to the environment-react-ssr playground? Maybe later on we can have a more generic one for these tests.

I will give it a go, probably I can integrate these tests into that playground.

Maybe can we write this as unit test? We have a few tests manually target createServer and createBuilder API like below, so we could do the same for resolve.alias since it doesn't require driving web page and I think it's generally easier to author tests and faster.

vite/packages/vite/src/node/ssr/__tests__/ssrLoadModule.spec.ts

Lines 66 to 67 in 40f45f6

	test('virtual module invalidation', async () => {
	const server = await createServer({

vite/packages/vite/src/node/__tests__/build.spec.ts

Lines 611 to 613 in 40f45f6

	test('emitAssets', async () => {
	const builder = await createBuilder({
	root: resolve(__dirname, 'fixtures/emit-assets'),

I'm not sure if we have a single spec file testing both dev and build, but maybe we could add something like packages/vite/src/node/__tests__/environment.spec.ts?

[lazarv]

Maybe can we write this as unit test?

Thanks @hi-ogawa very good suggestion! I implemented the test as a unit test now and yes it's much performant and also produces less noise.

@patak-dev I checked your suggested change and it works with one caveat. It seems the consumer needs to add a plugin and use the undocumented createIdResolver to resolve the id using the current environment.

let idResolver: ResolveIdFn
return {
  name: 'environment-alias-test-plugin',
  configResolved(config) {
    idResolver = createIdResolver(config, {})
  },
  async resolveId(id) {
    return await idResolver(this.environment, id)
  },
}

[patak-dev]

Sorry for the delay @lazarv! Thanks for the PR 🙏🏼