fix: handle encoded base paths #17577
Open
+289
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
added
p3-minor-bug
|
|
bluwy
commented
Jun 27, 2024
There was a problem hiding this comment.
This file is largely a copy of the other test files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the changes from #15311 (and tweaks thereafter) (Vite 5.2), I believe it broke most cases of
basethat contains encoded base paths, e.g./foo%20bar/, which Vite encodes internally even if you pass/foo bar/.I'm somewhat relieved that we didn't get a lot of reports of this, because
basepaths that look like this are hard 🥲Because
resolvedConfig.baseis a URL-encoded string, when we merge it with some un-encoded strings, and encode the merged string, thebaseportion will get double encoded. The solution in this PR is to decode thebasefirst.In the future, maybe we can revisit if we want to have
resolvedConfig.basebe decoded only, or introduce a newresolvedConfig.decodedBase? Or we can say we don't support strange base paths.NOTE: I also updated the code in
plugin-legacytogether as I noticed it while searching the codebase.