Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from v5 #1548

Merged
merged 8 commits into from
Nov 1, 2024
Merged

Migration from v5 #1548

merged 8 commits into from
Nov 1, 2024

Conversation

jay-es
Copy link
Collaborator

@jay-es jay-es commented Sep 18, 2024

resolve #1538 resolve #1646 resolve #1653 resolve #1659

の反映です

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for vitejs-docs-ja ready!

Name Link
🔨 Latest commit 953a12b
🔍 Latest deploy log https://app.netlify.com/sites/vitejs-docs-ja/deploys/6720c4b9ae7c22000852d232
😎 Deploy Preview https://deploy-preview-1548--vitejs-docs-ja.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@shuuji3 shuuji3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guide/migration.md をレビューしてみましたが、完璧な翻訳でした。あとは docs/.vitepress/config.ts を更新するだけでマージできそうですね。

@jay-es
Copy link
Collaborator Author

jay-es commented Sep 22, 2024

@shuuji3 おぉ、レビューありがとうございます! 🙇
Vite 6 がリリースされたらマージしようと思っています。

config.ts はどこか足りないですかね? 👀

@shuuji3
Copy link
Contributor

shuuji3 commented Sep 22, 2024

もとのIssue #1538 の commit (vitejs/vite@242f550#diff-3def678deb1b1d5a53948eb8491817dde4dc881e032e785fc61cc93d334eefcd) で /changes/ 以下が追加されていたので、こちらのPRでも変更が必要かと思ったのですが、よく見たらすでに反映済みですね (https://github.com/vitejs/docs-ja/pull/1548/files#diff-b0e8d2b934072cfae76650bab06790f99d4564db7f0171dc52cd998f4744fffeR346) 🙏🏻 このままのconfig.tsで問題なさそうです!

@jay-es
Copy link
Collaborator Author

jay-es commented Nov 1, 2024

migration.md に関する issue が多くなってきたのでマージしてしまう

@jay-es jay-es merged commit c8e2a99 into vitejs:main Nov 1, 2024
5 checks passed
@jay-es jay-es deleted the 1538 branch November 1, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants