Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not await workbox-window messageSkipWaiting non-async function #795

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix: do not await workbox-window messageSkipWaiting non-async function #795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/client/build/register.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ export function registerSW(options: RegisterSWOptions = {}) {

let wb: import('workbox-window').Workbox | undefined
let registerPromise: Promise<void>
let sendSkipWaitingMessage: () => Promise<void> | undefined
let sendSkipWaitingMessage: () => void | undefined

const updateServiceWorker = async (_reloadPage = true) => {
await registerPromise
if (!auto) {
await sendSkipWaitingMessage?.()
sendSkipWaitingMessage?.()
}
}

Expand All @@ -48,12 +48,12 @@ export function registerSW(options: RegisterSWOptions = {}) {
if (!wb)
return

sendSkipWaitingMessage = async () => {
sendSkipWaitingMessage = () => {
// Send a message to the waiting service worker,
// instructing it to activate.
// Note: for this to work, you have to add a message
// listener in your service worker. See below.
await wb?.messageSkipWaiting()
wb?.messageSkipWaiting()
}
if (!autoDestroy) {
if (auto) {
Expand Down