Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Origin/alexander vidoni/fix missing dependency #25

Closed
wants to merge 2 commits into from
Closed

Origin/alexander vidoni/fix missing dependency #25

wants to merge 2 commits into from

Commits on Oct 18, 2024

  1. FIX ad missing dependency fast-glob to package.json template svelte (js)

    @alexander-vidoni
    alexander-vidoni committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    84f8e63 View commit details
    Browse the repository at this point in the history

  2. FIX Error in browser console, when loading the service-worker.js for … 

    …svelte

In Svelte and SvelteKit there is no index.html due to the routing. So / is the entrypoint to the app. I think that this should be reflected in the createHandlerBoundRoute() function. So I changed it to / and the uncaugth Error from the browsers console does no longer show up. Precaching works correct and the registration of the sevice woker is now possible without moving to state "redundant" any more.
I think that it was just a typo, because in the .ts files of template-custom-svelte-kit it was already set to "/".
    @alexander-vidoni
    alexander-vidoni committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6454eab View commit details
    Browse the repository at this point in the history